Skip to content

Make Day::new const and remove Day::__new_unchecked #73

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Make Day::new const and remove Day::__new_unchecked #73

wants to merge 2 commits into from

Conversation

tguichaoua
Copy link
Contributor

@tguichaoua tguichaoua commented Dec 6, 2024 •
edited
Loading

closes #72

Note: since this change uses Option::expect in a constant context, it requires rust 1.83 (28 November, 2024) or above.

@tguichaoua tguichaoua marked this pull request as draft December 6, 2024 18:41
@tguichaoua tguichaoua marked this pull request as ready for review December 6, 2024 18:55
@fspoettel
Copy link
Owner

thank you @tguichaoua - I'll merge this one after the current aoc completes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make new unchecked unsafe
2 participants
@tguichaoua @fspoettel